From 84ef0d9440edea460c2a175a3d6779fed1f1f568 Mon Sep 17 00:00:00 2001 From: dragonwocky Date: Mon, 19 Oct 2020 22:49:22 +1100 Subject: [PATCH] fix theming primary-colour text + right-to-left text in columns --- CHANGELOG.md | 2 ++ README.md | 5 +++-- mods/core/css/theme.css | 3 ++- mods/right-to-left/mod.js | 6 ++++-- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9433cb3..72b963d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -39,6 +39,8 @@ a flexibility update. `box-shadow`, `box-shadow_strong`, `select_input`, and `ui-border` - bugfix: font sizing applied to overlays/previews. - bugfix: removed typo in variable name for brown text. +- bugfix: primary-colour text (mainly in "add a \_" popups) is now properly themed. +- bugfix: right-to-left extension applies to text in columns. - tweak: sticky table/list rows. - theme: "material ocean" = an oceanic colour palette. - theme: "dracula" = a theme based on the popular dracula color palette diff --git a/README.md b/README.md index 91c4019..1f1f702 100644 --- a/README.md +++ b/README.md @@ -375,8 +375,9 @@ the font you would like to use, or leave it blank to not change anything. a couple months after I ([@dragonwocky](https://github.com/dragonwocky/)) picked the project up, at first extending upon the original base and later moving to the javascript module system. -since then, various community members have helped out heaps - some listed as +the enhancer wouldn't be anything near to what it is now though without +interested community members testing, coding and ideating features - some are listed as [contributors](https://github.com/dragonwocky/notion-enhancer/graphs/contributors) here on github, -but many helping with code, feedback and testing on discord and in emails. +but many more have been helping out on discord and in emails. individual modules have their original authors attributed. diff --git a/mods/core/css/theme.css b/mods/core/css/theme.css index 3ea2b56..dc1bb30 100644 --- a/mods/core/css/theme.css +++ b/mods/core/css/theme.css @@ -403,7 +403,8 @@ background: var(--theme--selected) !important; } -[style*=' color: rgb(46, 170, 220)'] { +[style*=' color: rgb(46, 170, 220)'], +[style^='color: rgb(46, 170, 220)'] { color: var(--theme--primary) !important; } [style*='fill: rgb(46, 170, 220)'] { diff --git a/mods/right-to-left/mod.js b/mods/right-to-left/mod.js index 270669a..3f1fb80 100644 --- a/mods/right-to-left/mod.js +++ b/mods/right-to-left/mod.js @@ -12,7 +12,7 @@ module.exports = { tags: ['extension'], name: 'right-to-left', desc: 'enables auto rtl/ltr text direction detection.', - version: '1.4.0', + version: '1.4.1', author: 'obahareth', hacks: { 'renderer/preload.js'(store, __exports) { @@ -48,7 +48,9 @@ module.exports = { function autoAlignPageContent() { document .querySelectorAll( - '.notion-page-content > div[data-block-id]:not([dir]), [placeholder="Untitled"]:not([dir])' + `.notion-page-content > div[data-block-id]:not([dir]):not(.notion-column_list-block), + [placeholder="Untitled"]:not([dir]), + .notion-column-block > div[data-block-id]:not([dir])` ) .forEach((block) => block.setAttribute('dir', 'auto')); document