#126 board view shadow, remove messenger emoji set, bugfix EACCES response

CHANGELOG.md

@@ -8,6 +8,13 @@
 - [advanced math editor](https://github.com/Manueloccorso/NotionMathEditor_BrowserExtension)
 - re-orderable extensions
 
+### v0.?.? (wip)
+
+- bugfix: removed messenger emoji set as the provider no longer supports it.
+- bugfix: remove shadow around light mode board headers
+  \+ minor text colour fixes for night shift theming.
+- bugfix: properly detect/respond to `EACCES` errors.
+
 ### v0.9.1 (2020-09-26)
 
 - bugfix: font chooser will continue iterating through fonts after encountering a blank option.

mods/core/css/theme.css

@@ -203,7 +203,9 @@
 
 .notion-body.dark
   [style*='box-shadow: rgba(15, 15, 15, 0.2) 0px 0px 0px 1px, rgba(15, 15, 15, 0.2) 0px 2px 4px'],
-.notion-body:not(.dark) [style*='box-shadow: white -3px 0px 0px'] {
+.notion-body:not(.dark)
+  .notion-dark-theme
+  [style*='box-shadow: white -3px 0px 0px'] {
   box-shadow: rgba(15, 15, 15, 0.1) 0px 0px 0px 1px,
     rgba(15, 15, 15, 0.1) 0px 2px 4px !important;
 }
@@ -425,8 +427,11 @@
 .notion-page-content [style*='color: inherit;'],
 .notion-frame .notion-page-block,
 .notion-body.dark [style*=' color: rgba(255, 255, 255, 0.9)'],
-.notion-body.dark [style*='color: rgba(255, 255, 255, 0.7)'],
+.notion-body.dark [style^='color: rgba(255, 255, 255, 0.9)'],
-.notion-body:not(.dark) [style*=' color: rgb(55, 53, 47);'] {
+.notion-body.dark [style*=' color: rgba(255, 255, 255, 0.7)'],
+.notion-body.dark [style^='color: rgba(255, 255, 255, 0.7)'],
+.notion-body:not(.dark) [style*=' color: rgb(55, 53, 47);'],
+.notion-body:not(.dark) [style^='color: rgb(55, 53, 47);'] {
   color: var(--theme--text) !important;
 }
 .notion-body.dark [style*='color: rgba(255, 255, 255, 0.6)'],

mods/emoji-sets/mod.js

@@ -29,7 +29,6 @@ module.exports = {
         'joypixels',
         'openmoji',
         'emojidex',
-        'messenger',
         'lg',
         'htc',
         'mozilla',
@@ -109,6 +108,15 @@ module.exports = {
                     el.style.display = 'none';
                     if (el.parentElement.getAttribute('contenteditable'))
                       el.remove();
+                  } else if (
+                    el.previousElementSibling.matches(
+                      'span[role="image"][aria-label]'
+                    )
+                  ) {
+                    el.previousElementSibling.innerText = el.getAttribute(
+                      'alt'
+                    );
+                    el.setAttribute('aria-label', el.getAttribute('alt'));
                   }
                 });
               } else {
@@ -116,11 +124,11 @@ module.exports = {
                   el.parentElement
                     .querySelectorAll('span[role="image"][aria-label]')
                     .forEach((text) => text.remove());
+                  el.style.display = 'inline-block';
                   if (!el.style.background.includes(store().style)) {
                     el.style.background = `url(https://emojicdn.elk.sh/${el.getAttribute(
                       'aria-label'
                     )}?style=${store().style})`;
-                    el.style.display = 'inline-block';
                     el.style.backgroundSize = 'contain';
                     el.style.backgroundRepeat = 'no-repeat';
                     el.style.opacity = 1;
@@ -135,12 +143,3 @@ module.exports = {
     },
   },
 };
-// span[role="image"][aria-label]
-/*  */
-
-// <div style="position: relative; width: 36px; height: 36px;">
-//   <img class="notion-emoji" alt="😀" aria-label="😀" src="data:image/gif;base64,R0lGODlhAQABAIAAAP///wAAACH5BAEAAAAALAAAAAABAAEAAAICRAEAOw==" style="width: 36px; height: 36px; background: url(&quot;/images/twitter-emoji-spritesheet-64.png&quot;) 53.5714% 62.5% / 5700% 5700%; opacity: 1; transition: opacity 100ms ease-out 0s;">
-//   <img alt="😀" aria-label="😀" src="https://notion-emojis.s3-us-west-2.amazonaws.com/v0/svg-twitter/1f600.svg" style="position: absolute; top: 0px; left: 0px; opacity: 0; width: 36px; height: 36px;">
-// </div>
-
-//   <img class="notion-emoji" alt="✝" aria-label="✝" src="data:image/gif;base64,R0lGODlhAQABAIAAAP///wAAACH5BAEAAAAALAAAAAABAAEAAAICRAEAOw==" style="width: 100%; height: 100%; background: url(&quot;/images/twitter-emoji-spritesheet-64.png&quot;) 98.2143% 25% / 5700% 5700%;">

mods/emoji-sets/styles.css

@@ -1,5 +0,0 @@
-.notion-emoji::after {
-  content: attr(aria-label, '');
-  width: 1em;
-  height: 1em;
-}

pkg/apply.js

@@ -112,11 +112,15 @@ module.exports = async function ({ overwrite_version, friendly_errors } = {}) {
     return true;
   } catch (err) {
     console.error('### ERROR ###');
-    if (err.toString().includes('EACCESS') && friendly_errors) {
+    if (err.code === 'EACCES' && friendly_errors) {
       console.error(
-        'file access forbidden: try again with sudo or in an elevated/admin prompt.'
+        `file access forbidden - ${
+          process.platform === 'win32'
+            ? 'make sure your user has elevated permissions.'
+            : `try running "chown -R ${err.path}"`
+        }`
       );
-    } else if (err.toString().includes('EIO') && friendly_errors) {
+    } else if (err.code === 'EIO' && friendly_errors) {
       console.error('file access failed: is notion running?');
     } else console.error(err);
     return false;

pkg/remove.js

@@ -114,11 +114,15 @@ module.exports = async function ({
     return true;
   } catch (err) {
     console.error('### ERROR ###');
-    if (err.toString().includes('EACCESS') && friendly_errors) {
+    if (err.code === 'EACCES' && friendly_errors) {
       console.error(
-        'file access forbidden: try again with sudo or in an elevated/admin prompt.'
+        `file access forbidden - ${
+          process.platform === 'win32'
+            ? 'make sure your user has elevated permissions.'
+            : `try running "chown -R ${err.path}"`
+        }`
       );
-    } else if (err.toString().includes('EIO') && friendly_errors) {
+    } else if (err.code === 'EIO' && friendly_errors) {
       console.error('file access failed: is notion running?');
     } else console.error(err);
     return false;