tabs: fallback if text name is undefined

This commit is contained in:
dragonwocky 2020-11-02 15:58:10 +11:00
parent 2a20d67be2
commit eb3aa26220
Signed by: dragonwocky
GPG Key ID: C7A48B7846AA706D
2 changed files with 4 additions and 4 deletions

View File

@ -168,7 +168,7 @@ these include:
| new tab keybinding | [accelerator](https://github.com/electron/electron/blob/master/docs/api/accelerator.md) input | `CommandOrControl+T` | | new tab keybinding | [accelerator](https://github.com/electron/electron/blob/master/docs/api/accelerator.md) input | `CommandOrControl+T` |
| close tab keybinding | [accelerator](https://github.com/electron/electron/blob/master/docs/api/accelerator.md) input | `CommandOrControl+W` | | close tab keybinding | [accelerator](https://github.com/electron/electron/blob/master/docs/api/accelerator.md) input | `CommandOrControl+W` |
![](https://user-images.githubusercontent.com/16874139/97819548-5b5c2080-1cfd-11eb-9c3d-cbf586dc7235.png) ![](https://user-images.githubusercontent.com/16874139/97821456-9dd62b00-1d06-11eb-8c3a-e9f77bbd740e.png)
### tweaks ### tweaks

View File

@ -387,7 +387,7 @@ module.exports = (store, __exports) => {
title = title =
(this.state.tabs.get(+id).emoji (this.state.tabs.get(+id).emoji
? `${this.state.tabs.get(+id).emoji} ` ? `${this.state.tabs.get(+id).emoji} `
: '') + this.state.tabs.get(+id).text; : '') + (this.state.tabs.get(+id).text || 'Notion Desktop');
if (electronWindow && electronWindow.getTitle() !== title) if (electronWindow && electronWindow.getTitle() !== title)
electronWindow.setTitle(title); electronWindow.setTitle(title);
} }
@ -439,7 +439,7 @@ module.exports = (store, __exports) => {
const electronWindow = electron.remote.getCurrentWindow(), const electronWindow = electron.remote.getCurrentWindow(),
title = title =
(event.args[0].emoji ? `${event.args[0].emoji} ` : '') + (event.args[0].emoji ? `${event.args[0].emoji} ` : '') +
event.args[0].text; (event.args[0].text || 'Notion Desktop');
if ( if (
event.target.id == this.views.current.id && event.target.id == this.views.current.id &&
electronWindow.getTitle() !== title electronWindow.getTitle() !== title
@ -749,7 +749,7 @@ module.exports = (store, __exports) => {
}, },
React.createElement('span', { React.createElement('span', {
dangerouslySetInnerHTML: { dangerouslySetInnerHTML: {
__html: (title.img || '') + title.text, __html: (title.img || '') + (title.text || 'notion.so'),
}, },
}), }),
React.createElement( React.createElement(