mirror of
https://github.com/notion-enhancer/notion-enhancer.git
synced 2025-04-04 04:39:03 +00:00
macos bugfixes: #151 dark mode detection in night shift + adding menubar to extensions menu + padding-left with tabs to give traffic lights space
This commit is contained in:
parent
35bbb12524
commit
f66c78a381
GPG Key ID:
C7A48B7846AA706D
@ -27,6 +27,7 @@ a flexibility update.
|
||||
- improved: use keyup listeners instead of a globalShortcut for the enhancements menu toggle.
|
||||
- improved: overwrite `app.asar.bak` if already exists (e.g. for app updates).
|
||||
- improved: additional menu option descriptions on hover.
|
||||
- improved: listen to prefers-color-scheme to better change theme in night shift.
|
||||
- bugfix: removed messenger emoji set as the provider no longer supports it.
|
||||
- bugfix: remove shadow around light mode board headers
|
||||
\+ minor text colour fixes for night shift theming.
|
||||
@ -47,6 +48,9 @@ a flexibility update.
|
||||
- bugfix: right-to-left extension applies to text in columns.
|
||||
- bugfix: block text colour applies to text with backgrounds.
|
||||
- bugfix: font applied to wrong mode with littlepig dark.
|
||||
- bugfix: keep "empty" top bar visible in the menu.
|
||||
- bugfix: set NSRequiresAquaSystemAppearance to false in /Applications/Notion.app/Contents/Info.plist
|
||||
so system dark/light mode can be properly detected.
|
||||
- tweak: sticky table/list rows.
|
||||
- theme: "material ocean" = an oceanic colour palette.
|
||||
- theme: "dracula" = a theme based on the popular dracula color palette
|
||||
@ -62,6 +66,11 @@ a fork of notion-deb-builder that does generate an app.asar has been created and
|
||||
- bugfix: windows are properly hidden/shown on macOS.
|
||||
- extension: "tweaks" = common style/layout changes.
|
||||
|
||||
MACOS SPECIFIC FIXES
|
||||
|
||||
- close to tray: perma-true
|
||||
- frameless mode: perma-false
|
||||
|
||||
### v0.9.1 (2020-09-26)
|
||||
|
||||
- bugfix: font chooser will continue iterating through fonts after encountering a blank option.
|
||||
|
||||
@ -117,6 +117,9 @@ s {
|
||||
#titlebar .window-buttons-area:empty {
|
||||
display: none;
|
||||
}
|
||||
[data-platform='darwin'] #titlebar {
|
||||
height: 2.65em;
|
||||
}
|
||||
|
||||
/* alerts */
|
||||
|
||||
|
||||
@ -75,6 +75,9 @@ body,
|
||||
flex-direction: column;
|
||||
}
|
||||
|
||||
[data-platform='darwin'] #titlebar {
|
||||
padding-left: 4em;
|
||||
}
|
||||
#titlebar::before {
|
||||
content: '';
|
||||
position: absolute;
|
||||
|
||||
@ -14,6 +14,8 @@ const store = require('../../pkg/store.js'),
|
||||
{ toKeyEvent } = require('keyboardevent-from-electron-accelerator');
|
||||
|
||||
window['__start'] = async () => {
|
||||
document.body.setAttribute('data-platform', process.platform);
|
||||
|
||||
// mod loader
|
||||
const modules = helpers.getEnhancements();
|
||||
if (modules.loaded.length)
|
||||
|
||||
@ -972,6 +972,8 @@ module.exports = (store, __exports) => {
|
||||
|
||||
window['__start'] = () => {
|
||||
document.head.innerHTML += `<link rel="stylesheet" href="${__dirname}/css/tabs.css" />`;
|
||||
document.body.setAttribute('data-platform', process.platform);
|
||||
|
||||
const modules = getEnhancements();
|
||||
for (let mod of modules.loaded) {
|
||||
for (let font of mod.fonts || []) {
|
||||
|
||||
@ -12,7 +12,7 @@ module.exports = {
|
||||
name: 'night shift',
|
||||
desc:
|
||||
'sync dark/light theme with the system (overrides normal theme setting).',
|
||||
version: '0.1.1',
|
||||
version: '0.1.2',
|
||||
author: 'dragonwocky',
|
||||
hacks: {
|
||||
'renderer/preload.js'(store, __exports) {
|
||||
@ -23,19 +23,22 @@ module.exports = {
|
||||
const notion_elem = document.querySelector('.notion-app-inner');
|
||||
if (!notion_elem) return;
|
||||
clearInterval(attempt_interval);
|
||||
process([{ target: notion_elem }]);
|
||||
const observer = new MutationObserver(process);
|
||||
handle([{ target: notion_elem }]);
|
||||
const observer = new MutationObserver(handle);
|
||||
observer.observe(notion_elem, {
|
||||
attributes: true,
|
||||
subtree: true,
|
||||
});
|
||||
function process(list, observer) {
|
||||
function handle(list, observer) {
|
||||
const mode = `notion-app-inner notion-${
|
||||
window.matchMedia('(prefers-color-scheme: dark)').matches
|
||||
? 'dark'
|
||||
: 'light'
|
||||
}-theme`;
|
||||
if (notion_elem.className !== mode) notion_elem.className = mode;
|
||||
window
|
||||
.matchMedia('(prefers-color-scheme: dark)')
|
||||
.addEventListener('change', handle);
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
107
pkg/Info.plist
Normal file
107
pkg/Info.plist
Normal file
@ -0,0 +1,107 @@
|
||||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
|
||||
<plist version="1.0">
|
||||
<dict>
|
||||
<key>AsarIntegrity</key>
|
||||
<string>{"checksums":{"app.asar":"ZpfV8GYpkh6txWRLY2kyhxy+u/IqxXQicxy6MJr5nNo+FpB7+OvoU+S+6vpgTFAriFyk1Vzdm3LL3r2YdtqkKQ==","electron.asar":"GSTmZZ4QxBFCHgDFXN5eV94sbMRBgM04kw+f9bM+XZB00NCsFz1+8yIOYHycj0X6OoxeOOi08sk4Epi5a2kCDQ=="}}</string>
|
||||
<key>BuildMachineOSBuild</key>
|
||||
<string>17D102</string>
|
||||
<key>CFBundleDisplayName</key>
|
||||
<string>Notion</string>
|
||||
<key>CFBundleExecutable</key>
|
||||
<string>Notion</string>
|
||||
<key>CFBundleIconFile</key>
|
||||
<string>Notion.icns</string>
|
||||
<key>CFBundleIdentifier</key>
|
||||
<string>notion.id</string>
|
||||
<key>CFBundleInfoDictionaryVersion</key>
|
||||
<string>6.0</string>
|
||||
<key>CFBundleName</key>
|
||||
<string>Notion</string>
|
||||
<key>CFBundlePackageType</key>
|
||||
<string>APPL</string>
|
||||
<key>CFBundleShortVersionString</key>
|
||||
<string>2.0.8</string>
|
||||
<key>CFBundleURLTypes</key>
|
||||
<array>
|
||||
<dict>
|
||||
<key>CFBundleTypeRole</key>
|
||||
<string>Editor</string>
|
||||
<key>CFBundleURLName</key>
|
||||
<string>notion</string>
|
||||
<key>CFBundleURLSchemes</key>
|
||||
<array>
|
||||
<string>notion</string>
|
||||
</array>
|
||||
</dict>
|
||||
</array>
|
||||
<key>CFBundleVersion</key>
|
||||
<string>2.0.8</string>
|
||||
<key>DTCompiler</key>
|
||||
<string>com.apple.compilers.llvm.clang.1_0</string>
|
||||
<key>DTSDKBuild</key>
|
||||
<string>10.13</string>
|
||||
<key>DTSDKName</key>
|
||||
<string>macosx10.13</string>
|
||||
<key>DTXcode</key>
|
||||
<string>0941</string>
|
||||
<key>DTXcodeBuild</key>
|
||||
<string>9F2000</string>
|
||||
<key>LSApplicationCategoryType</key>
|
||||
<string>public.app-category.productivity</string>
|
||||
<key>LSMinimumSystemVersion</key>
|
||||
<string>10.10.0</string>
|
||||
<key>NSAppTransportSecurity</key>
|
||||
<dict>
|
||||
<key>NSAllowsArbitraryLoads</key>
|
||||
<true/>
|
||||
<key>NSAllowsLocalNetworking</key>
|
||||
<true/>
|
||||
<key>NSExceptionDomains</key>
|
||||
<dict>
|
||||
<key>127.0.0.1</key>
|
||||
<dict>
|
||||
<key>NSIncludesSubdomains</key>
|
||||
<false/>
|
||||
<key>NSTemporaryExceptionAllowsInsecureHTTPLoads</key>
|
||||
<true/>
|
||||
<key>NSTemporaryExceptionAllowsInsecureHTTPSLoads</key>
|
||||
<false/>
|
||||
<key>NSTemporaryExceptionMinimumTLSVersion</key>
|
||||
<string>1.0</string>
|
||||
<key>NSTemporaryExceptionRequiresForwardSecrecy</key>
|
||||
<false/>
|
||||
</dict>
|
||||
<key>localhost</key>
|
||||
<dict>
|
||||
<key>NSIncludesSubdomains</key>
|
||||
<false/>
|
||||
<key>NSTemporaryExceptionAllowsInsecureHTTPLoads</key>
|
||||
<true/>
|
||||
<key>NSTemporaryExceptionAllowsInsecureHTTPSLoads</key>
|
||||
<false/>
|
||||
<key>NSTemporaryExceptionMinimumTLSVersion</key>
|
||||
<string>1.0</string>
|
||||
<key>NSTemporaryExceptionRequiresForwardSecrecy</key>
|
||||
<false/>
|
||||
</dict>
|
||||
</dict>
|
||||
</dict>
|
||||
<key>NSCameraUsageDescription</key>
|
||||
<string>This app needs access to the camera</string>
|
||||
<key>NSHighResolutionCapable</key>
|
||||
<true/>
|
||||
<key>NSHumanReadableCopyright</key>
|
||||
<string>Copyright © 2020 Notion Labs, Incorporated</string>
|
||||
<key>NSMainNibFile</key>
|
||||
<string>MainMenu</string>
|
||||
<key>NSMicrophoneUsageDescription</key>
|
||||
<string>This app needs access to the microphone</string>
|
||||
<key>NSPrincipalClass</key>
|
||||
<string>AtomApplication</string>
|
||||
<key>NSSupportsAutomaticGraphicsSwitching</key>
|
||||
<true/>
|
||||
<key>NSRequiresAquaSystemAppearance</key>
|
||||
<false/>
|
||||
</dict>
|
||||
</plist>
|
||||
12
pkg/apply.js
12
pkg/apply.js
@ -92,6 +92,18 @@ module.exports = async function ({ overwrite_version, friendly_errors } = {}) {
|
||||
}
|
||||
}
|
||||
|
||||
// patching app properties so dark/light mode can be detected
|
||||
if (
|
||||
process.platform === 'darwin' &&
|
||||
(await fs.pathExists(path.resolve(`${helpers.__notion}/../Info.plist`)))
|
||||
) {
|
||||
fs.copy(
|
||||
path.resolve(`${__dirname}/Info.plist`),
|
||||
path.resolve(`${helpers.__notion}/../Info.plist`),
|
||||
{ overwrite: true }
|
||||
);
|
||||
}
|
||||
|
||||
for await (let insertion_target of readdirIterator(
|
||||
path.resolve(`${helpers.__notion}/app`),
|
||||
{
|
||||
|
||||
Loading…
Reference in New Issue
Block a user